This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Improved visual styles of the image widget #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like something in between. I don't like the 2nd, heavier look, but I miss something in the 1st case when the nested editable has focus. That 1px border (not aligned to the sides of the image) looks somehow out of place. |
|
I've changed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Improved visual styles of the image widget . Closes ckeditor/ckeditor5#5036.
Additional information
I've created two versions.
First version (on this branch) copies styles from https://ckeditor5.github.io/ (bigger outline over image, and new color on hovering):
Second version (on t/12a branch) tries to get close to things proposed by @oleq in ckeditor/ckeditor5#5036 (no rounded borders because CSS outline doesn't suport that - if we really want it we should start using border-color on focus):
