This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Improved the performance of the ImageLoadObserver #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Improved markup operation performance of the editor with the image plugin enabled. Closes ckeditor/ckeditor5#5766.
Additional information
Do we want to add a test for that? I feel that integration test for this performance improvement would be a nice protection.
Example verification benchmarks:
master
branch): 11.01s to remove attributesNote that this was performed on a idling, real environment notebook, so other factor might distort the result. But it's in line with what you feel manually checking it, so it gives the right idea.
Markup used in the editor can be found here: https://gist.github.com/mlewand/109ae7e518cb91d90318c81331b7d37a
The further performance could be addressed by tweaking engine package.