Other: Updated balloon position names after refactoring in the Balloo…

…nPanelView class. Closes #92.
ckeditor · Apr 10, 2017 · 4da5be2 · 4da5be2
1 parent 0e8c6ca
commit 4da5be2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/image/ui/imageballoonpanelview.js b/src/image/ui/imageballoonpanelview.js
@@ -23,7 +23,7 @@ const positions = {
 		return {
 			top: targetRect.bottom + arrowVOffset,
 			left: targetRect.left + targetRect.width / 2 - balloonRect.width / 2,
-			name: 's'
+			name: 'arrow_s'
 		};
 	},
 
@@ -36,7 +36,7 @@ const positions = {
 		return {
 			top: targetRect.top - balloonRect.height - arrowVOffset,
 			left: targetRect.left + targetRect.width / 2 - balloonRect.width / 2,
-			name: 'n'
+			name: 'arrow_n'
 		};
 	}
 };

diff --git a/tests/image/ui/imageballoonpanelview.js b/tests/image/ui/imageballoonpanelview.js
@@ -141,12 +141,12 @@ describe( 'ImageBalloonPanel', () => {
 		const balloonRect = { width: 50, height: 20 };
 
 		const northPosition = north( targetRect, balloonRect );
-		expect( northPosition.name ).to.equal( 'n' );
+		expect( northPosition.name ).to.equal( 'arrow_n' );
 		expect( northPosition.top ).to.equal( targetRect.top - balloonRect.height - BalloonPanelView.arrowVerticalOffset );
 		expect( northPosition.left ).to.equal( targetRect.left + targetRect.width / 2 - balloonRect.width / 2 );
 
 		const southPosition = south( targetRect, balloonRect );
-		expect( southPosition.name ).to.equal( 's' );
+		expect( southPosition.name ).to.equal( 'arrow_s' );
 		expect( southPosition.top ).to.equal( targetRect.bottom + BalloonPanelView.arrowVerticalOffset );
 		expect( southPosition.left ).to.equal( targetRect.left + targetRect.width / 2 - balloonRect.width / 2 );
 	}