-
Notifications
You must be signed in to change notification settings - Fork 40
Improved filtering out disallowed attributes on child elements. #1790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the test that I added.
Unfortunately, this is much harder than this. Merging nodes creates completely new nodes on the fly – ones which are not present in the beginning.
We need to be creative and write a couple more tests where text nodes would be merged during the process. I fear that there's a range of potentially broken implementations that we need to avoid. I think that the implementation may look like this:
This will be safe because merging text nodes does not change positions. |
BTW, I don't remember why we're checking whether the right type of operation is used. I think that it is enough if one or two tests check that. The other ones don't have to. |
That was a really cool idea with |
I only removed |
Suggested merge commit message (convention)
Fix: Improved filtering out disallowed attributes on child elements. ckeditor/ckeditor5#4535.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.