Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Make markers created by Writer#insert() affect data. #1584

Merged
merged 2 commits into from
Oct 24, 2018
Merged

Conversation

ma2ciek
Copy link
Contributor

@ma2ciek ma2ciek commented Oct 24, 2018

Suggested merge commit message (convention)

Fix: Made markers created by Writer#insert() affect data. Closes ckeditor/ckeditor5#4438.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

coveralls commented Oct 24, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling c478a3e on t/1583 into f88c918 on master.

@pjasiun pjasiun requested a review from oskarwrobel October 24, 2018 15:21
@oskarwrobel
Copy link
Contributor

Travis says:

Chrome 70.0.3538 (Linux 0.0.0) Writer insert() should transfer markers from given DocumentFragment FAILED
	AssertionError: expected undefined to equal true
	    at Context.it (webpack:///./tests/model/writer.js?:331:38)

@oskarwrobel oskarwrobel merged commit 72aaaf0 into master Oct 24, 2018
@oskarwrobel oskarwrobel deleted the t/1583 branch October 24, 2018 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markers created by a data pipeline are not marked as affectsData
3 participants