-
Notifications
You must be signed in to change notification settings - Fork 40
Upcast writing and View enhancements #1579
Conversation
There is related PR (change in docs) in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in comments.
A control question – did you check for |
Co-Authored-By: f1ames <dr.odpowiedz@gmail.com>
Co-Authored-By: f1ames <dr.odpowiedz@gmail.com>
Co-Authored-By: f1ames <dr.odpowiedz@gmail.com>
Co-Authored-By: f1ames <dr.odpowiedz@gmail.com>
Co-Authored-By: f1ames <dr.odpowiedz@gmail.com>
Co-Authored-By: f1ames <dr.odpowiedz@gmail.com>
Co-Authored-By: f1ames <dr.odpowiedz@gmail.com>
Co-Authored-By: f1ames <dr.odpowiedz@gmail.com>
Co-Authored-By: f1ames <dr.odpowiedz@gmail.com>
When it comes to b0aa93b, I have changed all API samples which used protected constructors (e.g. It could be also changed to use |
Suggested merge commit message (convention)
Other: Introduced
createDocumentFragment()
,createElement()
andcreateText()
methods inUpcastWriter
. TheView.change()
method now returns result of its callback. Closes ckeditor/ckeditor5#4423.Additional information
See ckeditor/ckeditor5#4423 for details.