Changed also tests and the sibling code in the view.

ckeditor · Oct 26, 2018 · 0dca79e · 0dca79e
1 parent 8e37c8c
commit 0dca79e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/src/view/position.js b/src/view/position.js
@@ -288,7 +288,7 @@ export default class Position {
 	 * * {@link module:engine/view/position~Position.createAfter},
 	 * * {@link module:engine/view/position~Position.createFromPosition}.
 	 *
-	 * @param {module:engine/view/item~Item|module:engine/model/position~Position} itemOrPosition
+	 * @param {module:engine/view/item~Item|module:engine/view/position~Position} itemOrPosition
 	 * @param {Number|'end'|'before'|'after'} [offset] Offset or one of the flags. Used only when
 	 * first parameter is a {@link module:engine/view/item~Item view item}.
 	 */
@@ -305,9 +305,15 @@ export default class Position {
 			} else if ( offset == 'after' ) {
 				return this.createAfter( node );
 			} else if ( offset !== 0 && !offset ) {
+				/**
+				 * {@link module:engine/view/position~Position.createAt `Position.createAt()`}
+				 * requires the offset to be specified when the first parameter is a view item.
+				 *
+				 * @error view-position-createAt-offset-required
+				 */
 				throw new CKEditorError(
-					'view-position-createAt-required-second-parameter: ' +
-					'Position.createAt requires the second parameter offset when first parameter is a view item.' );
+					'view-position-createAt-offset-required: ' +
+					'Position.createAt() requires the offset when the first parameter is a view item.' );
 			}
 
 			return new Position( node, offset );

diff --git a/tests/model/position.js b/tests/model/position.js
@@ -159,7 +159,7 @@ describe( 'Position', () => {
 
 	describe( 'createAt()', () => {
 		it( 'should throw if no offset is passed', () => {
-			expect( () => Position.createAt( ul ) ).to.throw( CKEditorError, /model-position-createAt-required-second-parameter/ );
+			expect( () => Position.createAt( ul ) ).to.throw( CKEditorError, /model-position-createAt-offset-required/ );
 		} );
 
 		it( 'should create positions from positions', () => {

diff --git a/tests/view/position.js b/tests/view/position.js
@@ -155,7 +155,7 @@ describe( 'Position', () => {
 		it( 'should throw if no offset is passed', () => {
 			const element = new Element( 'p' );
 
-			expect( () => Position.createAt( element ) ).to.throw( CKEditorError, /view-position-createAt-required-second-parameter/ );
+			expect( () => Position.createAt( element ) ).to.throw( CKEditorError, /view-position-createAt-offset-required/ );
 		} );
 
 		it( 'should create positions from positions', () => {