This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Introduced EditorConfig#initialData. Made config param optional #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Mar 26, 2019
src/inlineeditor.js
Outdated
| * If a DOM element is passed, its content will be automatically | ||
| * {@link module:editor-inline/inlineeditor~InlineEditor#setData loaded} to the editor upon initialization | ||
| * and the {@link module:core/editor/editorui~EditorUI#getEditableElement editor element} will replace the passed element in the DOM | ||
| * (the original one will be hidden and the editor will be injected next to it). |
There was a problem hiding this comment.
Are you sure anything will be replaced in the inline editor?
pjasiun
reviewed
Mar 26, 2019
src/inlineeditor.js
Outdated
| * @returns {Promise} A promise resolved once the editor is ready. | ||
| * The promise returns the created {@link module:editor-inline/inlineeditor~InlineEditor} instance. | ||
| * Moreover, the editor data will be set back to the original element once the editor is destroyed and when a form, in which | ||
| * this element is contained, is submitted (if the original element is a `<textarea>`). This ensures seamless integration with native |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduced
EditorConfig#initialData.Additional information
Part of ckeditor/ckeditor5#1619.
Also, I've made
configparameter inEditor.create()optional. There is no need for it and we also have an example in docs without using it.