Used EditorUI#update instead of ViewDocument#render to pin panel.

ckeditor · Jun 26, 2018 · 73e6666 · 73e6666
1 parent 7ee4b1a
commit 73e6666
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/inlineeditorui.js b/src/inlineeditorui.js
@@ -49,7 +49,7 @@ export default class InlineEditorUI extends EditorUI {
 		}
 
 		// https://github.com/ckeditor/ckeditor5-editor-inline/issues/4
-		view.listenTo( editor.editing.view, 'render', () => {
+		view.listenTo( editor.ui, 'update', () => {
 			// Don't pin if the panel is not already visible. It prevents the panel
 			// showing up when there's no focus in the UI.
 			if ( view.panel.isVisible ) {

diff --git a/tests/inlineeditorui.js b/tests/inlineeditorui.js
@@ -80,17 +80,17 @@ describe( 'InlineEditorUI', () => {
 			} );
 
 			// https://github.com/ckeditor/ckeditor5-editor-inline/issues/4
-			it( 'pin() is called on editor.editable.view#render', () => {
+			it( 'pin() is called on editor.ui#update', () => {
 				const spy = sinon.stub( view.panel, 'pin' );
 
 				view.panel.hide();
 
-				editor.editing.view.render();
+				editor.ui.fire( 'update' );
 				sinon.assert.notCalled( spy );
 
 				view.panel.show();
 
-				editor.editing.view.render();
+				editor.ui.fire( 'update' );
 				sinon.assert.calledOnce( spy );
 				sinon.assert.calledWithExactly( spy, {
 					target: view.editableElement,