Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/ckeditor5/1838: Feature: Added an editor instance reference to the native editable DOM element under the ckeditorInstance property. #184

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Jun 27, 2019

Suggested merge commit message (convention)

Feature: Added an editor instance reference to the native editable DOM element under the ckeditorInstance property. Closes ckeditor/ckeditor5#1838.

Implemented the EditorUI#setEditableElement() method.
Deprecated the EditorUI#_editableElements property.


Additional information

A piece of ckeditor/ckeditor5#1840.

…tor instance reference to the native editable DOM element. Deprecated the EditorUI#_editableElements property.
@coveralls
Copy link

coveralls commented Jun 27, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 8830ae4 on t/ckeditor5/1838 into 21b3fd3 on master.

@oleq oleq marked this pull request as ready for review June 27, 2019 13:38
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, One typo found :D

src/editor/editorui.js Outdated Show resolved Hide resolved
Co-Authored-By: Maciej <jodator@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose editor instance in the editable DOM elements
3 participants