Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual test: plugins/button/manual/togglebuttons #5205

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

KarolDawidziuk
Copy link
Contributor

What is the purpose of this pull request?

Fix manual test.

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

skip.

What changes did you make?

IE older than version 10 has a problem with inserting generated content into tbody element. To fix this, I created the entire table structure in JS.

Which issues does your PR resolve?

Closes #5200.

@sculpt0r sculpt0r self-assigned this May 12, 2022
@sculpt0r sculpt0r self-requested a review May 12, 2022 08:34
Copy link
Contributor

@sculpt0r sculpt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 I'm adding a single comment in the code with a ref to the issue. Test is now working on lower IE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot test /tests/plugins/button/manual/togglebuttons
3 participants