Use underlying std::net::Ipv4Addr #26

ckcr4lyf · 2023-02-07T10:15:11Z

Removes "parsing" entirely, so getting the [u8; 6] of IP & port is much faster

benchmark:

IP str to bytes/&str    time:   [32.792 ns 32.899 ns 33.033 ns]
IP str to bytes/std::net::Ipv4Addr
                        time:   [2.0008 ns 2.0097 ns 2.0194 ns]

ckcr4lyf · 2023-02-07T10:22:50Z

src/byte_functions/mod.rs

-pub fn ip_str_port_u16_to_bytes(ip_str: &str, port: u16) -> [u8; 6] {
+// Convert the ipv4 addr, port combo to a [u8; 6]
+pub fn ip_str_port_u16_to_bytes(ip_addr: &std::net::Ipv4Addr, port: u16) -> [u8; 6] {
    let mut result: [u8; 6] = [0; 6];
-    let mut parts = ip_str.split('.');
+    let ip_octets = ip_addr.octets();

    for i in 0..4 {
-        result[i] = match parts.next() {
-            Some(v) => match v.parse::<u8>() {
-                Ok(v) => v,
-                Err(_) => 0,
-            }
-            None => 0,
-        }
-    }    
+        result[i] = ip_octets[i];
+    }



lets fucking go

ckcr4lyf added 2 commits February 7, 2023 18:14

Use underlying std::net::Ipv4Addr

f1f1361

Remove old parsing stuffs

63ee448

ckcr4lyf commented Feb 7, 2023

View reviewed changes

ckcr4lyf merged commit d7722eb into master Feb 7, 2023

ckcr4lyf mentioned this pull request Feb 9, 2023

(sometimes) skyrocketing announce latency, drop in requests per second #4

Closed

ckcr4lyf deleted the feature/parse-ip-fast branch September 4, 2024 03:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use underlying std::net::Ipv4Addr #26

Use underlying std::net::Ipv4Addr #26

ckcr4lyf commented Feb 7, 2023

ckcr4lyf Feb 7, 2023

Use underlying std::net::Ipv4Addr #26

Use underlying std::net::Ipv4Addr #26

Conversation

ckcr4lyf commented Feb 7, 2023

ckcr4lyf Feb 7, 2023

Choose a reason for hiding this comment