Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to pyproject.toml #236

Merged
merged 2 commits into from
Dec 4, 2024
Merged

chore: switch to pyproject.toml #236

merged 2 commits into from
Dec 4, 2024

Conversation

duttonw
Copy link
Collaborator

@duttonw duttonw commented Nov 24, 2024

@duttonw duttonw requested a review from amercader November 24, 2024 22:18
@duttonw duttonw self-assigned this Nov 24, 2024
@duttonw
Copy link
Collaborator Author

duttonw commented Nov 24, 2024

Hi (@ThrawnCA , @JVickery-TBS , @amercader , @davidread , @kowh-ai , @pdelboca , @wardi )

Can you confirm and let me know if you are happy to be listed on the authors/maintainers as well as if that is your preferred email address.

I've ordered the authors based on most recent work as well as most contributions and maintainers via pypi listing. (tho with how we have just configured github actions auto deploy, that list may need to reflect who has 'maintainer' rights on this project (who can cut versions etc).

Regards,

@duttonw

@duttonw duttonw force-pushed the chore_pyproject-toml branch from cb18bb1 to 17e8f71 Compare November 24, 2024 22:32
@ThrawnCA
Copy link
Collaborator

@duttonw I'd prefer to use my work email for this repo.

@duttonw duttonw force-pushed the chore_pyproject-toml branch 2 times, most recently from 651165e to 3e2209c Compare November 24, 2024 23:19
@davidread
Copy link
Contributor

Thanks for this, but please just use my name, not email

@JVickery-TBS
Copy link
Contributor

@duttonw Yeah that sounds great! And yeah that account is good (for now, will let you know if I move from TBS and then we can move to my personal github).

Currently I do not have a lot of capacity, but hopefully will be able to do some small bug reports and fixes.

@duttonw duttonw force-pushed the chore_pyproject-toml branch from 3e2209c to 9ae3b5b Compare November 26, 2024 20:33
@duttonw
Copy link
Collaborator Author

duttonw commented Nov 26, 2024

@davidread

Thanks for this, but please just use my name, not email

removed.

@duttonw
Copy link
Collaborator Author

duttonw commented Nov 26, 2024

Hi ( @amercader , @kowh-ai , @pdelboca , @wardi ),

Just a reminder to ensure you happy with or with to have alterations on the author/maintainer details (name/email component).

I'm looking at merging this PR on the 4th of Dec 2024 as I've had 50% response rate on their preference with said details.

Regards,

@duttonw

@duttonw duttonw marked this pull request as ready for review November 26, 2024 20:39
@amercader
Copy link
Member

@duttonw Keeping mine is fine, but I think it's safer to not include emails unless people have given explicit consent, as these will pop up in pypi or be inevitably harvested for spam.

@duttonw
Copy link
Collaborator Author

duttonw commented Nov 27, 2024

@duttonw Keeping mine is fine, but I think it's safer to not include emails unless people have given explicit consent, as these will pop up in pypi or be inevitably harvested for spam.

Have removed for the others who have not responded. (did leave datashades group mailbox though)

@duttonw duttonw merged commit 27b4c03 into master Dec 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants