Skip empty lines instead of erroring #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a unit test sample that has an extra empty line. This ideally should be handled gracefully (ie ignore the extra line)
Extra empty lines at the end of a file should be ignored.
Skip rows that are completely blank instead of erroring out
Can't provide range and single element in the same 'list' call, split them
duttonw
reviewed
Mar 15, 2024
duttonw
reviewed
Mar 15, 2024
duttonw
requested changes
Mar 15, 2024
That's outside the scope of this PR; it's not really fixable as part of a direct COPY. Also, there could be some cases where a blank row is the intended result and other cases where it's not wanted. |
duttonw
approved these changes
Mar 15, 2024
JVickery-TBS
pushed a commit
to open-data/ckanext-xloader
that referenced
this pull request
May 8, 2024
Skip empty lines instead of erroring # Conflicts: # ckanext/xloader/loader.py ### RESOLVED.
JVickery-TBS
added a commit
to open-data/ckanext-xloader
that referenced
this pull request
May 8, 2024
…58953d3f7cc19f7df2b40 Merge pull request ckan#208 from ckan/github-206-empty-lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure Tabulator to ignore empty rows, #206