#182 Type guessing fixes #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ThrawnCA
commented
Apr 18, 2023
•
- Fix fallback to 'str' type on columns that mix numeric and string.
- Fix parsing of empty strings as 'numeric' or 'timestamp', by converting them to None.
- Increase CSV sample size to ensure that quote characters are correctly guessed.
- Columns that used numeric on some rows and free text on others resulted in no type being guessed and an error
…#182 - 'timestamp' and 'numeric' cannot handle empty strings, so convert to None
duttonw
approved these changes
Apr 18, 2023
RossWebsterWork
approved these changes
May 23, 2023
- Messytables used to use 1000 rows, the Tabulator approach should do the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.