Support patching pre-commit hooks written in bash #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🔨 Split conditional * 🔨 Replace `if not continue` with `if` * ✨ Add bash version * 🔨 Add comments with pre-commit version ranges * 🔨 Extract variable `patches` * 🔨 Move bash fragment into `patches` * 🔨 Slide comments * 🔨 Replace `if...elif` with `for...if...break` loop over `patches` * 🔨 Do not duplicate `patches` keys * 🔨 Inline variable `header` * 🔨 Rename variable `patches` to `headers` * 🔨 Rename variable `patch` to `header` * 🔨 Support multiple languages when checking for bindir * ✨ Support bash when checking for bindir * 🔨 Slide `bindirs` before loop * 🐛 Fix over-aggressive quote removal for bindir in bash hooks * 🔨 Inline variable `bindirs` into `bindirs` * 💡 Expand comment * 🔨 Slide `headers` before loop * 🔨 Replace `lines[0].startswith` with `hook.read_bytes().startswith` * 🐛 Do not attempt to decode hooks unless they have a shebang Retrocookie-Original-Commit: cjolowicz/cookiecutter-hypermodern-python-instance@b2a958a
The patched pre-commit hooks installed by the `pre-commit` Nox session modify the `PATH` environment variable, using `os.pathsep` to separate prepended paths. On Git Bash for Windows, `os.pathsep` is a shell-special character and needs to be quoted. This commit quotes the path separator. This fixes the following error on Windows when invoking pre-commit from Git: ``` .git/hooks/pre-commit: line 3: C:\Users\User\hypermodern-python\.nox\pre-commit\Scripts: Is a directory .git/hooks/pre-commit: line 13: dirname: command not found An error has occurred: FatalError: git failed. Is it installed, and are you in a Git repository directory? ``` Retrocookie-Original-Commit: cjolowicz/cookiecutter-hypermodern-python-instance@2d133a0
* fix Windows support by handling sh shebangs from pre-commit * More specific pattern to detect sh shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shshebangs from pre-commit (Bump actions/setup-python from 4.0.0 to 4.6.1 #1121)