Do not duplicate nox.Session interface in type stubs #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicating the nox.Session interface in our type stubs is extremely brittle and likely to break with every Nox interface. Instead, pretend that our Session derives from nox.Session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the type stubs distributed with nox-poetry to pretend that
nox_poetry.Sessionderives fromnox.Session.Rationale:
Currently, the type stubs for the
sessionsmodule duplicate thenox.Sessioninterface. This is done becausenox_poetry.Sessiondelegates tonox.Sessionvia__getattr__. Unfortunately, this has some chance of breaking type checkers with every Nox release. For example, a Noxfile passingposargstosession.notify(introduced in Nox 2021.6.6) will not pass type checks, ifsessionis an instance ofnox_poetry.Session.