Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse(::Type{InfExtendedTime}, ...) #28

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

omus
Copy link
Contributor

@omus omus commented Aug 11, 2020

Fixes: #27. Something I missed in #22.

@omus omus changed the title Fix parse(::Type{InfExtendedTime}, ...) Fix parse(::Type{InfExtendedTime}, ...) Aug 11, 2020
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          190       194    +4     
=========================================
+ Hits           190       194    +4     
Impacted Files Coverage Δ
src/infextendedtime/parse.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d8fa31...18f97ef. Read the comment docs.

@cjdoris cjdoris merged commit 5b5decc into cjdoris:master Aug 12, 2020
@cjdoris
Copy link
Owner

cjdoris commented Aug 12, 2020

Thanks, yeah I didn't know that parse didn't automatically call tryparse.

@omus omus deleted the cv/parse-fix branch August 12, 2020 13:25
@omus
Copy link
Contributor Author

omus commented Aug 12, 2020

I found that out by experimentation. I figured one would call the other. What I unfortunately didn't test was with the InfExtendedTime type's parse... Oh, well, fixed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse(::Type{InfExtendedTime{Date}}, ::AbstractString) doesn't dispatch to Infinity.jl
2 participants