Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ZonedDateTime #20

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Support ZonedDateTime #20

merged 2 commits into from
Jun 19, 2020

Conversation

fchorney
Copy link
Contributor

Closes #19

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        17    +1     
  Lines          173       175    +2     
=========================================
+ Hits           173       175    +2     
Impacted Files Coverage Δ
src/Infinity.jl 100.00% <100.00%> (ø)
src/infextendedtime/timezones.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d07e19c...b876385. Read the comment docs.

@cjdoris
Copy link
Owner

cjdoris commented Jun 18, 2020

Can you use Requires.jl to remove the dependency on TimeZones.jl? I'd rather only depend on things truly required for the core functionality.

Perhaps put an __init__ function in init.jl, which does

@require TimeZones="..." include("timezones.jl")

@fchorney
Copy link
Contributor Author

oh interesting. Yeah I'll look into using Requires

@fchorney
Copy link
Contributor Author

Not sure if there is a better way to do the tests, or if this is good?

@cjdoris cjdoris merged commit 90038fe into cjdoris:master Jun 19, 2020
@cjdoris
Copy link
Owner

cjdoris commented Jun 19, 2020

Looks good, yes I'm happy with any dependencies for testing.

@fchorney
Copy link
Contributor Author

@cjdoris thanks for letting me do all these PR's! Are the last few going to be registered as 0.2.1?

@cjdoris
Copy link
Owner

cjdoris commented Jun 19, 2020

Yes I'll register it now. Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ZonedDateTime
3 participants