Consolidate common functions. Add to README #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 16 -2
Lines 189 168 -21
=========================================
- Hits 189 168 -21
Continue to review full report at Codecov.
|
|
@cjdoris any comments or thoughts on this and the other PR's? Would love to get this moving along. |
|
Cool, thanks. This will make it much easier to add new InfExtended types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
Wasn't sure if we wanted a whole subfolder with split files vs this common file. I felt like having a subfolder with such little code in each file felt unnecessarily verbose, but I can switch back to that if we want.
Tried to abstract out any functions that were the same. Edited the readme a bit to add dates information, and fix up the
InfExtendedstuff.