Restructure code, and rename InfExtended to InfExtendedReal #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 53.27% 54.23% +0.95%
==========================================
Files 8 13 +5
Lines 122 118 -4
==========================================
- Hits 65 64 -1
+ Misses 57 54 -3
Continue to review full report at Codecov.
|
|
Thanks very much. Yes this and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5
I tried moving everything in the way we discussed previously. Let me know if I moved something in a place you weren't wanting.
I also decided to do the renaming of InfExtended to InfExtendedReal. Since this is a breaking change, and this package isn't at 1.0.0 yet, I just renamed it and bumped the version to 0.2.0. Not sure if we want to set a deprecation cycle for this.