Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TestingEmbulk instead of EmbulkEmbed #9

Merged
merged 12 commits into from
Jan 26, 2020
Merged

Use TestingEmbulk instead of EmbulkEmbed #9

merged 12 commits into from
Jan 26, 2020

Conversation

civitaspo
Copy link
Owner

This PR must be reviewed after #8 is merged because this branch's root is the branch of #8.
When you check this PR before #8 is merged, please see this file changes: civitaspo:a56fa76...civitaspo:57d951c.

  • Change the dependency: org.embulk:embulk-core:0.9.23:tests -> org.embulk:embulk-test:0.9.23
  • Use TestingEmbulk instead of EmbulkEmbed

… is deprecated (since 2.13.0): Use `scala.jdk.CollectionConverters` instead
…d `: Unit =` to explicitly declare `setAuthMethod_Profile`'s return type
…ated: see corresponding Javadoc for more information.
…der in class InstanceProfileCredentialsProvider is deprecated: see corresponding Javadoc for more information.
…r of the new SDK interface may change significantly.
…ap is deprecated: see corresponding Javadoc for more information.
…mbulkEmbed's interface may changes in the future.
@civitaspo civitaspo requested a review from higarin January 23, 2020 22:44
@civitaspo civitaspo changed the title Use embulk-test instead of EmbulkEmbed Use TestingEmbulk instead of EmbulkEmbed Jan 23, 2020
@higarin higarin merged commit 4f9b868 into civitaspo:master Jan 26, 2020
@civitaspo civitaspo mentioned this pull request Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants