BUG In Travis, restrict pandas version downloaded #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas dropped Python 3.4 support with v0.21, and our Python 3.4 tests have recently begun failing when they attempt to install the newest version. Our Travis tests were installing all of the optional packages in a separate line; move those to their own requirements file so that we can control which version is intalled where. See also pandas-dev/pandas#20697 .
77ab528 to
5ce217e
Compare
keithing
reviewed
Apr 17, 2018
full-testing-requirements.txt
Outdated
| pandas<0.21; python_version == '3.4' | ||
| pandas<=0.23; python_version == '2.7' | ||
| scikit-learn | ||
| scipy |
There was a problem hiding this comment.
Why not add these to dev-requirements.txt?
keithing
suggested changes
Apr 17, 2018
|
The separate file did seem strange, but I couldn't remember why we didn't put those extra requirements in dev-requirements to begin with. I moved them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas dropped Python 3.4 support with v0.21, and our Python 3.4 tests have recently begun failing when they attempt to install the newest version. Our Travis tests were installing all of the optional packages in a separate line; move those to the dev-requirements file so that we can control which version is installed where. See also pandas-dev/pandas#20697 .