Remove obsolete declare calls. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mollux. I didn't notice this PR when it was submitted, @xurizaemon pointed out the same issue in http://civicrm.stackexchange.com/questions/16314/does-civicrm-have-a-recommended-setting-for-zend-multibyte This fixes an problem where the test suite prints out a long, weird debug message on many dev systems. I'd like to merge since it was an upstream change (released in upstream's v1.8), although I feel a little ignorant about the topic of email character sets. I'm working on a test run on |
|
Test suite passed modulo one common/unrelated false-negative ( |
totten
added a commit
to totten/civicrm-core
that referenced
this pull request
Mar 14, 2017
On many systems, the test suite outputs a long message which begins with: ``` PHP Warning: declare(encoding=...) ignored because Zend multibyte feature is turned off by settings in /path/to/sites/all/modules/civicrm/vendor/zetacomponents/mail/src/transports/variable/var_set.php on line 2 ``` This patch addresses the warning by updating the version of ezcMail (aka `zetacomponents/mail`). See also: * civicrm/zetacomponents-mail#1 * http://civicrm.stackexchange.com/questions/16314/does-civicrm-have-a-recommended-setting-for-zend-multibyte
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
On many systems, the test suite outputs a long message which begins with: ``` PHP Warning: declare(encoding=...) ignored because Zend multibyte feature is turned off by settings in /path/to/sites/all/modules/civicrm/vendor/zetacomponents/mail/src/transports/variable/var_set.php on line 2 ``` This patch addresses the warning by updating the version of ezcMail (aka `zetacomponents/mail`). See also: * civicrm/zetacomponents-mail#1 * http://civicrm.stackexchange.com/questions/16314/does-civicrm-have-a-recommended-setting-for-zend-multibyte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on zetacomponents@da509f6