Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

Filter out empty lines from discount array #242

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Filter out empty lines from discount array #242

merged 1 commit into from
Sep 23, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 11, 2020 •
edited
Loading

Without this array_filter the array is winding up as [0 => ''] and failing to apply the discount based on later
empty() checks

With this patch I see the discount applied after I submit
Screen Shot 2020-09-11 at 4 37 28 PM

@eileenmcnaughton
Filter out empty lines from discount array
a038c90 
Without this array_filter the array is winding up as [0 => ''] and failing to apply the discount based on later
empty() checks
@eileenmcnaughton eileenmcnaughton mentioned this pull request Sep 11, 2020
Merged
@eileenmcnaughton
Copy link
Contributor Author

@colemanw not sure if this relates to your recent change? There is also a recent pr #240 you might check

@eileenmcnaughton eileenmcnaughton merged commit 51f379c into civicrm:master Sep 23, 2020
@eileenmcnaughton eileenmcnaughton deleted the master branch September 23, 2020 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eileenmcnaughton