Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary phone number does not save when included as part of a profile #91

Closed
scoobird opened this issue Jan 4, 2021 · 6 comments · Fixed by civicrm/civicrm-core#19321

Comments

@scoobird
Copy link

scoobird commented Jan 4, 2021

Noticed this with profiles created as blocks within contact layout editor as well as ones set up the traditional way. If you leave location of the phone as primary, the phone number is visible and appears editable in the block, but doesn't save when text is changed. When a location type other than Primary is specified it works as expected.

@colemanw
Copy link
Member

colemanw commented Jan 4, 2021

To clarify your bug report, are you saying that regular profile forms within CiviCRM (unrelated to this extension) have the same problem of being unable to save Primary Emails?

@scoobird
Copy link
Author

scoobird commented Jan 4, 2021

Nope, not an issue with Civi profiles (at least not that I've noticed)! Within the context of this extension -- it doesn't matter how the profile was created. Hope that helps?

To clarify your bug report, are you saying that regular profile forms within CiviCRM (unrelated to this extension) have the same problem of being unable to save Primary Emails?

@colemanw
Copy link
Member

colemanw commented Jan 4, 2021

I tried this on my local test site (running the latest version of Civi + ContactLayout)

  1. Create a layout
  2. Click the + Block button
  3. In the "Unnamed profile" dialog, add 1 field to the profile: "Email (Primary)"
  4. Save the layout.
  5. Create a new contact
  6. From their summary screen, click the profile block to add an email address (works)
  7. Observe new email address appears in the block
  8. Click the block again to edit the email address (also works)

With these steps I am unable to reproduce the bug.

@scoobird
Copy link
Author

scoobird commented Jan 4, 2021

Those were the steps I followed, but it is updating the Primary Phone field where I experience the issue, not email. Thanks!

colemanw added a commit to colemanw/civicrm-core that referenced this issue Jan 5, 2021
This fixes the phone profile field to have the correct field key to match profile forms.
Fixes civicrm/org.civicrm.contactlayout#91
@colemanw
Copy link
Member

colemanw commented Jan 5, 2021

Ok I was able to reproduce for Phone field. Can you try out the fix linked above?
Or if you prefer a patch, here it is: https://patch-diff.githubusercontent.com/raw/civicrm/civicrm-core/pull/19321.diff

colemanw added a commit to colemanw/civicrm-core that referenced this issue Jan 5, 2021
This fixes the phone profile field to have the correct field key to match profile forms.
Fixes civicrm/org.civicrm.contactlayout#91
@scoobird
Copy link
Author

scoobird commented Jan 6, 2021

Thank you @colemanw -- I tested and can confirm it's resolved

@colemanw colemanw closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants