Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21052 - Encourage CiviCase 5 users to change revision-tracking #14

Merged
merged 2 commits into from
Aug 28, 2017

Conversation

totten
Copy link
Member

@totten totten commented Aug 10, 2017

No description provided.


public function checkActivityRevisionSetting() {
$messages = array();
if (Civi::settings()->get('civicaseActivityRevisions')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this setting defined?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see it now in civicrm/civicrm-core#10842

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, exactly. That's why I did this as a PR rather than pushing directly -- it depends on 10842.

@colemanw colemanw merged commit 5c01650 into civicrm:master Aug 28, 2017
@totten totten deleted the master-log-warn branch August 28, 2017 19:43
swastikpareek pushed a commit to swastikpareek/org.civicrm.civicase that referenced this pull request Oct 22, 2019
…-all-link

C51-150: Display download all link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants