-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't crash on windows #2
Conversation
Windows doesn't like the multiline command.
I tested this and it works for me @totten |
…cters more aggressively.
@demeritcowboy @seamuslee001 Ah, interesting problem. So at first glance, I thought this was OK - but then it struck me: "What data in that command involves newline characters?" Most of the args shouldn't. It's probably the Are you guys down with 90990bf - i.e. passing the
(Note: the command actually appears as one-line, but I've edited for readability on github ui). |
It's clever - give me a few minutes to try it out. |
Runs good. There's just some whitespace that snuck into line 49. |
Good catch @demeritcowboy. (Apparently my PSR-12 style-checker doesn't complain about that...) Whitespace fixed. Tests pass again. Merging. |
Tagged as v0.7. |
Thanks guys! |
Windows doesn't like the multiline command.