Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning caused by passing null to strpos #300

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

colemanw
Copy link
Member

Overview

Fixes a bunch of PHP warnings when you visit the CiviCRM home page (dashboard) without a q= argument in the URL.

Before

Home page looks like this:
image

After

Home page looks like this:
image

Technical Details

There was no reason to return NULL in a variable that was supposed to be a string.

@kcristiano
Copy link
Member

This looks good and r-run removes the error on php 8.1. Also did an r-run on php 7.4 with no issues.

@kcristiano kcristiano merged commit 000ee07 into civicrm:master Aug 13, 2023
@colemanw colemanw deleted the argString branch August 13, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants