Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom actions for rendering admin pages #292

Merged
merged 1 commit into from
May 11, 2023

Conversation

christianwach
Copy link
Member

Overview

Fixes this issue on Lab.

Before

PHP warnings from plugins such as:

PHP Warning:  Attempt to read property "ID" on null in /path/to/httpdocs/wp-content/plugins/acf-extended/includes/module-post.php on line 39

After

No PHP warnings.

@kcristiano
Copy link
Member

@christianwach It read like a good change to me, but all PRs are failing test E2E_Core_PathUrlTest/testGetUrl_WpAdmin/ here . I am thinking we may need to ignore that one.

@seamuslee001 @totten any input? I tried to fix the test but it passes sporadically on my buildkit local install

@christianwach
Copy link
Member Author

Is it this test that's failing? I don't have phpunit here, but looking at those assertEquals() statements, they shouldn't be failing given the output of cv('url civicrm/contribute?reset=1') on my machine. Weird.

@christianwach
Copy link
Member Author

@kcristiano Thanks for reviewing 👍

@kcristiano
Copy link
Member

test this please

@kcristiano
Copy link
Member

Re-tested against master. Code is good and r-run is successful.

Test fail is unrelated and all tests pass locally.

@kcristiano kcristiano merged commit e00c2f4 into civicrm:master May 11, 2023
@christianwach christianwach deleted the lab-wp-139 branch July 12, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants