revert 240 Remove Base Page content filter once it has been use #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Cristiano <kcristiano@kcristiano.com>
|
@kcristiano - I take it you & @christianwach are in agreement on this (which is my criteria for merging wp prs) |
|
merged after confirming that @christianwach is away & can't weigh in in the timeframe we need but is generally aware of the issue & this makes sense as a quick response to a regression |
|
Tested on a couple of sites that we were having the issue on, both the Civi basepage and using a shortcode as well, and this change fixes the problems I was having in issue #112. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://lab.civicrm.org/dev/wordpress/-/issues/112 and https://lab.civicrm.org/dev/wordpress/-/issues/107
Getting redirect loop in some cases, and a confirmation page just showing the shortcoden in all others.
Suggest revert.
This should also be backported to ESR.
ping @eileenmcnaughton