Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pages and metabox from loading until CiviCRM is installed #247

Merged
merged 2 commits into from
Mar 27, 2021

Conversation

christianwach
Copy link
Member

Overview

The CiviCRM Settings and Integration pages and the Quick Add Metabox should not load unless CiviCRM has been installed. Follow up PR to #245

Before

Pages and Metabox load during installation.

After

Pages and Metabox do not load during installation.

Comments

The Quick Add Metabox was calling CiviCRM_For_WordPress::initialize() during the install process and causing an infinite redirect. This is fixed as a result of this PR.

Also applies the correct @since tag to the new methods.

@kcristiano
Copy link
Member

Thanks @christianwach This looks good. passes r-run

@kcristiano kcristiano merged commit 61c2e34 into civicrm:master Mar 27, 2021
@christianwach christianwach deleted the lab-wp-96-2 branch June 4, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants