This repository has been archived by the owner on Aug 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Combine InstallSchema, AvailableTables
The main issue here is that `schema.tpl` is getting the wrong data. It was getting the DB name ```php generateCreateSql($model->srcPath, $model->db['database'], $model->tables) ``` But it should actually the full, parsed schema specification: ``` generateCreateSql($model->srcPath, $spec->database, $spec->tables) ``` So basically... `InstallSchema` needs access to the full `$specification` (which was only available in `AvailableTables`). And I don't currently see a use-case that requires exposing the schema as part of the installer model, so I think it's simpler to merge `AvailableTables` into `InstallSchema`.
- Loading branch information
Showing
3 changed files
with
32 additions
and
46 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters