Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-15522 make "Null" not evaluate as null if N is capitalized #79

Merged
merged 1 commit into from
Oct 29, 2014

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented Oct 24, 2014


----------------------------------------
* CRM-15522: Last name Null disappears
  https://issues.civicrm.org/jira/browse/CRM-15522
@totten
Copy link
Member

totten commented Oct 24, 2014

Whoa, that is clever. :) It still scares me a little... but less scary than I was expecting...

@davecivicrm davecivicrm self-assigned this Oct 28, 2014
@davecivicrm
Copy link
Contributor

Test this please

@totten
Copy link
Member

totten commented Oct 29, 2014

The concept of this seems OK. It hopefully goes without saying if a user enters last name as "null", then it will still be mishandled by Civi, but at least we'll handle the well-formed name "Null" properly, and we don't need to go on a wild-goose-chase for lines/use-cases that depend on the current/wonky behavior.

I can't think of a case that's likely to break. It is, of course, a good idea to test inputs in a different situations (e.g. profile forms, "Edit Contact", importer).

The only project I can think of that systematically manipulates case of names would be https://civicrm.org/extensions/capitalisation-corrector ( @futurefirst / @JohnFF ) but don't think there'd ever be a conflict between them.

@agh1
Copy link
Contributor Author

agh1 commented Oct 29, 2014

I did a quick grep for "Null" (in quotes) that didn't turn up anything (while "null" yields a lot), so I don't thiink any of the wacky places where null is saved as a string have it in proper case.

davecivicrm added a commit that referenced this pull request Oct 29, 2014
CRM-15522 make "Null" not evaluate as null if N is capitalized
Looks like we have consensus that this is safe to merge.
@davecivicrm davecivicrm merged commit 2c79f19 into civicrm:4.5 Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants