[REF][PHP8.2] IDS fixes for dynamic property deprecation #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
braders
commented
Jun 10, 2023
| @@ -160,7 +167,6 @@ protected function __construct($config) | |||
| } elseif (is_array($config)) { | |||
| $this->recipients[] = $config['recipients']; | |||
| $this->subject = $config['subject']; | |||
| $this->additionalHeaders = $config['header']; | |||
There was a problem hiding this comment.
additionalHeaders was not being used anywhere, so rather than declare the property, I removed this line.
|
Very unfortunate about the upstream; patching Packages is the only expedient solution so here we go... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 8.2 dynamic properties are deprecated: https://php.watch/versions/8.2/dynamic-properties-deprecated. Some tests on PHP 8.2 are failing due to deprecation notices coming from IDS (and the deprecations would occur in general usage of CiviCRM.
The upstream library does not seem to be maintained, and PHP 8.1 patches were applied direct to CiviCRM packages. Therefore I have not opened an upstream PR.
Whilst I was here I also fixed some bad PHPDoc comments.