Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.2] IDS fixes for dynamic property deprecation #363

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

braders
Copy link
Contributor

@braders braders commented Jun 10, 2023

In PHP 8.2 dynamic properties are deprecated: https://php.watch/versions/8.2/dynamic-properties-deprecated. Some tests on PHP 8.2 are failing due to deprecation notices coming from IDS (and the deprecations would occur in general usage of CiviCRM.

The upstream library does not seem to be maintained, and PHP 8.1 patches were applied direct to CiviCRM packages. Therefore I have not opened an upstream PR.

Whilst I was here I also fixed some bad PHPDoc comments.

@civibot
Copy link

civibot bot commented Jun 10, 2023

(Standard links)

@civibot civibot bot added the master label Jun 10, 2023
@@ -160,7 +167,6 @@ protected function __construct($config)
} elseif (is_array($config)) {
$this->recipients[] = $config['recipients'];
$this->subject = $config['subject'];
$this->additionalHeaders = $config['header'];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionalHeaders was not being used anywhere, so rather than declare the property, I removed this line.

@colemanw
Copy link
Member

Very unfortunate about the upstream; patching Packages is the only expedient solution so here we go...

@colemanw colemanw merged commit 61ff395 into civicrm:master Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants