Update class_image.php for PHP8 #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"each" removed in PHP8
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
jenkins test this please |
kcfinder/lib/class_image.php
Outdated
| list($key, $width) = each($image); | ||
| list($key, $height) = each($image); | ||
| $width = $image[0]; | ||
| $height = $image[1]; |
There was a problem hiding this comment.
Technically this would fail if somebody did something like $gd = new image_gd(['w' => 200, 'h' => 200]);. I don't see it used that way anywhere, but it might be safer to use
$width = array_shift($image);
$height = array_shift($image);There was a problem hiding this comment.
That looks good to me. I updated the pull request.
There was a problem hiding this comment.
Great. I see this is your first contribution. Thanks for this. For release notes credit can do you do another PR to add yourself to this file: https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml
There was a problem hiding this comment.
jenkins add to whitelist
|
jenkins add to whitelist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"each" removed in PHP8