[php8-compat] Fix calling method_exist with paremeter that is bool not an object in… #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
what else would it be? is this a flaw in the upstream code or in our usage/ hacks to this? |
|
@eileenmcnaughton it was complaining it was an integer iirc so maybe but it was pretty early on in the process so this resolves it at least |
|
test this please |
|
Ok - I guess this particular function is already hacked so it might be our hack that is bad. I'm not keen on hacking packages but this just an extra check I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… php8
like civicrm/civicrm-core#20443 this just adds a check to make sure that $result is actually a class object
ping @eileenmcnaughton @totten