Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2366 - php 7.4 - Deprecated function get_magic_quotes_gpc #315

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

demeritcowboy
Copy link
Contributor

https://lab.civicrm.org/dev/core/-/issues/2366

  • The first if block never runs because get_magic_quotes_gpc() always returns false.
  • The second if block always runs because php version is always > 5.3
  • So just do the second block.

@civibot
Copy link

civibot bot commented Feb 6, 2021

(Standard links)

@demeritcowboy
Copy link
Contributor Author

Unit test is at civicrm/civicrm-core#19851

@seamuslee001
Copy link
Contributor

Looks good merging now

@seamuslee001 seamuslee001 merged commit c127df8 into civicrm:master Mar 20, 2021
@demeritcowboy demeritcowboy deleted the magic-quotes branch March 20, 2021 13:28
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants