dev/translation#50 Make recapture library locale aware

[seamuslee001]

This picks up the patch from https://civicrm.stackexchange.com/questions/11533/recaptcha-update-language/37503 by @adixon

@mattwire @mlutfy @MikeyMJCO

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[adixon]

Thank for this. I wasn't convinced this is the right approach - including civi-specific code within a library seems wrong - but least we've now got a conversation. The right solution would be to update the upstream library upstream with a patch that included language in the library call as a parameter, and then include that getLocale call in the civi code that calls the library function. Or maybe there's already a better upstream version? Yeah, that's a whole new can of worms.

[homotechsual]

It's the right can of worms imo. We should avoid patching third party libraries and opt for libraries that meet our needs or upstream patches.

[homotechsual]

I'm not sure what library we're using but the official PHP lib is supported and language aware... https://github.com/google/ReCAPTCHA

[homotechsual]

Definitely in favour of the effort going towards "modern recaptcha" library vs patch ancient unsupported library.

[adixon]

So, that leaves us with the work of trying to update the places in civi code that are using this newer version of the library and update the calls to what is almost certainly a more modern and complicated library ...

[homotechsual]

Work we're going to have to do anyway eventually... either when PHP makes something in this 2007 code break or when Google turn off RECAPTHA v2.

I'm going to look at what it would take to switch - the invocation of both is pretty similar and this would give us scope to introduce v3 support which has been requested.

[homotechsual]

So the library I linked is more for server-side verification. There is no client side replacement, seems like we'd be better off dropping the library and moving the functions to generate recaptcha elements directly into core.

All the library seems to be doing is inserting the HTML for the recaptcha elements?

[seamuslee001]

@MikeyMJCO the library also does the post to run the validation I think as well but this pr will need to be redone once #317 is merged

[seamuslee001]

closing as this is now conflicted