Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger for smarty error event #292

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented May 10, 2020

See civicrm/civicrm-core#16918

They need to be merged at the same time.

We can't override this function in CRM_Core_Smarty because it actually gets triggered from the Smarty_Compiler class which is not inherited.

Previously smarty errors (such as parse errors) were silently ignored in most cases making debugging templates extremely difficult.

@civibot
Copy link

civibot bot commented May 10, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

as per civicrm/civicrm-core#16918 confirmed that this works merging

@seamuslee001 seamuslee001 merged commit 089fafc into civicrm:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants