Remove unused Selenium binaries #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview -------- Remove binary copy of Selenium server, because it's not used. On a local copy of `civicrm-packages.git`, it reduces the size of the extant files from 33mb to 13mb. This is really just follow-up to 5.13's civicrm/civicrm-core#13861 Hopefully, some day, Selenium or a similar E2E mechanism will rise again in better form. But it will probably look different (composer/docker/npm-ified), and there's no point in carrying the `.jar` file in here.
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove binary copy of Selenium server, because it's not used.
On a local copy of
civicrm-packages.git, it reduces the size of the extant files from 33mb to 13mb.This is really just follow-up to 5.13's civicrm/civicrm-core#13861
Hopefully, some day, Selenium or a similar E2E mechanism will rise again in
better form. But it will probably look different (composer/docker/npm-ified), and there's no point in carrying the
.jarfile in here.