Fix continue / break warning under PHP 7.3

[ejegg]

PHP 7.3 has started to issue warnings when a continue statement is
inside a switch and interpreted as a break
"continue" targeting switch is equivalent to "break".
Did you mean to use "continue 2"?
In this case, it looks like 'continue 2' is the right way to go.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[ejegg]

strange, api_v3_JobProcessMailingTest::testConcurrency.testConcurrency is failing with all its datasets, but it's hard to tell what this commit could have done. The other 1000+ tests are passing, though!

[eileenmcnaughton]

@ejegg that test had a known issue after a server rebuild....

I agree with your analysis on continue 2 being correct. It's a dog of a construct though!

if ($val & DB_DATAOBJECT_STR) {
    $ret[$key] = Validate::string($this->$key, VALIDATE_PUNCTUATION . VALIDATE_NAME);
    continue;
}

if (($val & DB_DATAOBJECT_INT):
   $ret[$key] = Validate::number($this->$key, array('decimal'=>'.'));
   continue;
}

would save some braincells IMHO

[eileenmcnaughton]

test this please

[seamuslee001]

test this please

[eileenmcnaughton]

merging per previous discussion on this code (above)