Upgrade Smarty to 2.6.31 to solve issues on PHP7.2 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc411dc to
9cc7df8
Compare
totten
reviewed
May 15, 2018
| @@ -556,7 +551,7 @@ function _compile_tag($template_tag) | |||
|
|
|||
| case 'php': | |||
| /* handle folded tags replaced by {php} */ | |||
| list(, $block) = each($this->_folded_blocks); | |||
| $block = array_shift($this->_folded_blocks); | |||
There was a problem hiding this comment.
Most of the changes look like clear equivalents. The loop through $this->_folded_blocks is the only one which feels like it could potentially have side-effects (depending on how $this->_folded_blocks is used elsewhere), but I'd defer to upstream if they like it.
|
(CiviCRM Review Template WORD-1.1)
Thanks, @seamuslee001 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.