(WIP) CRM-18408, update for TLS issues seen in PHP5.6 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP5.6 introduces peer validation by default - this is a good thing. But it makes some TLS negotiation issues visible too. This ports changes from Net_SMTP-1.7.1 to our ancient patched 2011 version. We could also update Net_SMTP properly, but our version is modified so that wants review.
|
Closing this PR in favour of #184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP5.6 introduces peer validation by default - this is a good thing.
But it makes some TLS negotiation issues visible too. This ports changes from Net_SMTP-1.7.1 to our ancient patched 2011 version.
We could also update Net_SMTP properly, but our version is modified so that wants review.
This works for the specific site I was able to test (Elasticemail).
This commit accidentally includes 1f656ec which should remain but be separately committed.