Fixes broken links on post-upgrade/install page #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Featured old/broken links to wiki/confluence; update fixes to point to new docs. NB: not using the DocURL2 function as couldn't find documentation for it, instead linking directly to the doc url, so have adjusted the markup to include the link text.
|
Thanks @vingle |
|
Thanks for the merge @aydun! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joomla upgrade and installation screen featured five broken links to register a site and access docs (described here), this fixes them.
After on J3 (no change from before)
After on J4
Notes
Previously the upgrade and installation success links gave the same link to the upgrade guide, even if installing the first time; this now links to the Joomla upgrade guide when upgrading and Joomla install guide when installing.
Links were previously generated with a function docURL2 - I couldn't find documentation for it. On trying what looked like a more recent 'docURL' function (civicrm/civicrm-core#16065) it outputted a link with 'learn more' as the text, so I adopted the simplest option on the assumption that a) a fix is better than broken links; b) the link text remains potentially translatable (although none of this copy is in {ts}); and b) someone wanting to change those links in the future may be as puzzled as me, but could at least easily adjust URLs in this page. Can make a new PR using DocURL if someone can point me to an explainer.