Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable contribution views to filter on empty Receipt and Thank You dates #573

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Apr 11, 2019

Adding 'allow empty' => TRUE to filter definitions for dates enables the is empty / is not empty filter options.

Useful if you want a view showing contributions that have/have not been thanked.

Before: A view filter on Thank You date or Receipt Date does not offer empty/not empty

After: A view filter on Thank You date or Receipt Date does offer empty/not empty

@civibot
Copy link

civibot bot commented Apr 11, 2019

(Standard links)

@civibot civibot bot added the 7.x-master label Apr 11, 2019
@seamuslee001
Copy link
Contributor

This makes sense to me and seems fine code wise

@seamuslee001
Copy link
Contributor

I have tested this locally and confirms it works merging

@seamuslee001 seamuslee001 merged commit 534c7a6 into civicrm:7.x-master Apr 22, 2019
@aydun
Copy link
Contributor Author

aydun commented Apr 24, 2019

Thanks @seamuslee001 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants