WIP: CRM-20751: Support Drupal aliases for event links in Views #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9914e49 to
00406a5
Compare
|
Hi @colemanw I'd like to get your feedback on this please. BTW, there are civilint errors that were already there before; is it preferable for me to clean them up in this PR? |
|
@twomice I'm curious to know why not patch the |
|
@twomice for that matter, why not have those functions pass the job off to Drupal and skip the |
|
That would expand the scope to "all of CiviCRM Views" instead of just "Events in Views", but yeah, I'm cool with that. Will give it a try. |
|
Seems like a comfortable middle-ground between "just events in views"
and "all of CiviCRM core"
…On 06/21/2017 03:10 PM, Allen Shaw wrote:
That would expand the scope to "all of CiviCRM Views" instead of just
"Events in Views", but yeah, I'm cool with that. Will give it a try.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#455 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACveIKMXsszuhjS-UmMkgqFxhVFFgh0kks5sGWq_gaJpZM4OAELm>.
|
This reverts commit 00406a5.
|
Jenkins test this please. |
d3067ce to
b7d7ee8
Compare
|
@colemanw Right, that makes sense. So here it is. This looks right and works for me. |
|
I like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darn, need to fix civilint errors.