Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unit tests based on older framework #71

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

demeritcowboy
Copy link
Contributor

I don't think these tests work anymore because they are based on simpletest. In any case the community has an equivalent installation test that runs regularly.

@mglaman these aren't your tests but you'd probably be the best person to confirm that they are old and simpletest doesn't work anymore.

I came to these trying to find the base class while thinking about https://github.com/eileenmcnaughton/civicrm_entity/issues/348 and there are two in this repo named civicrmtestbase so I was initially confused, so removing this would also remove some confusion.

@mglaman
Copy link
Contributor

mglaman commented Feb 7, 2022

These are old and don't run. There is the base class added in this module... or maybe it's still in CiviCRM Entity or Webform CiviCRM. Either way, those two modules have a lot of testing infrastructure and items that could be moved to helpers here (maybe?) Or at least provide plenty of examples.

@demeritcowboy
Copy link
Contributor Author

Thanks @mglaman. Yes the base class is still here and still used: https://github.com/civicrm/civicrm-drupal-8/blob/a77a3a36720510bc23e9c51835933af8132a2aba/tests/src/FunctionalJavascript/CiviCrmTestBase.php

I know there are at least two sets of helper functions out there. I don't know if there's value in trying to move them here yet.

@demeritcowboy demeritcowboy merged commit b55fb50 into civicrm:master Feb 7, 2022
@demeritcowboy demeritcowboy deleted the old-test branch February 7, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants