Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing route cachability metadata in CiviCRM #102

Closed
wants to merge 4 commits into from

Conversation

gitressa
Copy link
Contributor

@gitressa gitressa commented Jan 9, 2025

@gitressa
Copy link
Contributor Author

gitressa commented Jan 9, 2025

The current patch does not work ... I get this at /admin/reports/dblog:

The website encountered an unexpected error. Try again later.

Error: Call to undefined method Symfony\Component\Routing\Route::addCacheContexts() in Drupal\civicrm\CivicrmBreadcrumbBuilder->applies() (line 41 of modules/contrib/civicrm/src/CivicrmBreadcrumbBuilder.php).

Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
@demeritcowboy
Copy link
Contributor

I do see that option here although I don't see it in the core repo. I think it was decided a long time ago not to use it because of some problem it causes.

Also there are some style check fails so I just made another PR to fix those and squash and then faked your name on the commit: #103

@demeritcowboy
Copy link
Contributor

Since this is your first contribution here, can you make another PR in the core repo to add yourself to this file for release notes credit: https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml

@gitressa
Copy link
Contributor Author

gitressa commented Jan 9, 2025

Thanks for the help, it's great that this got fixed so fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants