-
Notifications
You must be signed in to change notification settings - Fork 124
Conversation
Tag me for review when you're ready. |
c4d900f
to
2ed7177
Compare
I think it's ready now. I wasn't sure about the last line, or even if including it whether that lab space is where it should live. As an aside I was able to get mkdocs installed for previewing, but the only way I could get php code hiliting to work was with the 3 backticks and specifying php, otherwise no matter I did it seemed to be random hiliting or for a language I didn't recognize, possibly turtle-logo 🐢 . Also this would be for civi 5.29. |
Looks good from my end @MikeyMJCO |
A few brief comments from the linting pass :-) looks good otherwise! |
2ed7177
to
a8c4478
Compare
Thanks updated as per feedback. So this is awaiting release 5.29. |
@MikeyMJCO Just curious: why are you not merging? |
It's an interesting point that technically the feature is available to developers now if they're developing against master. I was mistakenly thinking along the lines of end-user features which are more tied to release numbers. So maybe a more general question is should there be a standard in the dev docs for identifying what versions a feature is available or discontinued. Maybe there is one and I'm not aware of it, or I just need to add some text in the docs somewhere "Added in 5.29"? |
@demeritcowboy I'd really like to see somewhere a developer orientated list of added/removed/modified per version so you can easily track what version supports what. But it's probably a lot of work.. |
It will be supported soon via meta-data embedded into the docs. The truth really is that I forget which book I'm looking at PRs for and assign to milestones incorrectly :-p Merging :-) |
WIP docs for civicrm/civicrm-core#17901